-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubmatic: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp #4000
base: master
Are you sure you want to change the base?
Pubmatic: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp #4000
Conversation
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coded unit tests are fine, but we look at the json test coverage since that includes additional assertions for memory safety. Please add json tests to cover this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SyntaxNode Can you please review the latest changes?
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report
|
@SyntaxNode Can you please review and merge the latest changes? |
No description provided.