Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovrn: Accept Imp.ext Bidfloor either as a number or string #3955

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ikagotso
Copy link
Contributor

@ikagotso ikagotso commented Oct 4, 2024

purpose of this commit is to fix this issue : #3514

Copy link

github-actions bot commented Oct 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3e1298a

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:28:	MakeRequests		84.6%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:134:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:140:	MakeBids		84.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:194:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:212:	getTagId		100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:220:	getImpIdx		100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:233:	Builder			100.0%
total:								(statements)		87.5%

@przemkaczmarek przemkaczmarek self-assigned this Oct 10, 2024
@bsardo
Copy link
Collaborator

bsardo commented Nov 4, 2024

Hi @ikagotso, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants