-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeta Global SSP: Add sid parameter and audio support #3939
base: master
Are you sure you want to change the base?
Zeta Global SSP: Add sid parameter and audio support #3939
Conversation
Code coverage summaryNote:
zeta_global_sspRefer here for heat map coverage report
|
@@ -1,5 +1,8 @@ | |||
endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA | |||
disabled: true | |||
endpoint: https://ssp.disqus.com/bid/prebid-server?sid={{.AccountID}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@przemkaczmarek I'm sorry, I didn't get it (cannot upload your img). Yes, the endpoint is reachable. And sid
query param is not mandatory in current implementation. What is the issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abermanov-zeta its not a issue, we just checking that endpoint is reachable. To merge PR 2ppl have to accept it. So if i check endpoint secound person dont have to.
When Ypu have cheanged endpoinyt we Have to check it one more time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@przemkaczmarek got it, thank you
userSync: | ||
redirect: | ||
url: https://ssp.disqus.com/redirectuser?sid=GET_SID_FROM_ZETA&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}} | ||
url: https://ssp.disqus.com/redirectuser?sid={{.AccountID}}&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AccountID
is not currently a supported macro for user sync URLs. We can add it. It should be noted that if it is not provided in the request to the cookie sync endpoint, the account ID will be set to "unknown".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsardo Yes, thank you. I've seen lists in macros.go. Having it in userSync is not critical for us, but would be great to have.
Hi @abermanov-zeta, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are |
No description provided.