New Adapter: Kobler #3904
New Adapter: Kobler #3904
Conversation
* New Adapter: Kobler
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| var bidExt openrtb_ext.ExtBid | ||
| err := json.Unmarshal(bid.Ext, &bidExt) | ||
| if err == nil && bidExt.Prebid != nil { | ||
| mediaType, err := openrtb_ext.ParseBidType(string(bidExt.Prebid.Type)) |
There was a problem hiding this comment.
Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
koblerRefer here for heat map coverage report |
|
Hello @bsardo @przemkaczmarek, what can I expect as an estimate for merging this, and is there anything I can contribute with to move this forward? |
| endpoint: "https://bid.essrtb.com/bid/prebid_server_rtb_call" | ||
| endpointCompression: gzip | ||
| maintainer: | ||
| email: [email protected] |
There was a problem hiding this comment.
I sent email, please confirm
| @@ -0,0 +1,12 @@ | |||
| endpoint: "https://bid.essrtb.com/bid/prebid_server_rtb_call" | |||
There was a problem hiding this comment.
endpoint is reachable
| return a.endpoint | ||
| } | ||
|
|
||
| func getMediaTypeForBid(bid openrtb2.Bid) openrtb_ext.BidType { |
There was a problem hiding this comment.
Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
There was a problem hiding this comment.
our adapter has a way of reading the mtype/markup type from our bidder in the current implementation.
Since we currently only support banner ads, we by default return the banner bid type if nothing is specified.
Code coverage summaryNote:
koblerRefer here for heat map coverage report |
|
@przemkaczmarek Hello, is there anything blocking this for a second reviewer and is there anything I can do to help speed this process up? |
|
Thank you for the review so far. @bsardo When do you think you have time to review this? |
|
Hi @TommyHPettersen, I'll give this a look as soon as the following is addressed. We recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are |
Code coverage summaryNote:
koblerRefer here for heat map coverage report |
|
Thank you for the response @bsardo, i have now updated all the package imports to Hope this helps! |
docs - prebid/prebid.github.io#5587