CPMStar: use iframe based usersync #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaMGoldstein
changed the title
bretg
requested changes
May 6, 2024
There was a problem hiding this comment.
can I convince you to leave the redirect approach in place and just add the iframe?
It better to have both approaches available for 2 reasons:
- iframe syncs don't work for AMP
- some publishers control iframe-vs-redirect sync
If you don't supply both options, you'll get left out in some scenarios.
If the publisher doesn't specify preferences, PBS will return the iframe sync.
|
Thanks Bret, I updated to have both sync types. |
gargcreation1992
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPMStar: Use iframe based usersync