Freewheel: add video dur and cat #3640

mwang-sticky · 2024-04-25T02:24:50Z

No description provided.

adapters/freewheelssp/freewheelssp.go

github-actions · 2024-04-25T02:25:36Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7ecef76

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

adapters/freewheelssp/freewheelssp.go

github-actions · 2024-04-25T02:48:35Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d0f5acf

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

adapters/freewheelssp/freewheelssp.go

github-actions · 2024-04-25T07:48:05Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 098262d

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

static/bidder-info/default.profraw

github-actions · 2024-04-25T13:32:07Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c385343

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

adapters/freewheelssp/freewheelssp_test.go

github-actions · 2024-04-29T10:13:51Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a26a598

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

gargcreation1992 · 2024-04-29T10:51:58Z

@mwang-sticky PR checks are failing because of - expected.ImpIDs must contain at least one imp ID

github-actions · 2024-04-29T16:21:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 37db0df

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

mwang-sticky · 2024-04-29T16:28:56Z

@mwang-sticky PR checks are failing because of - expected.ImpIDs must contain at least one imp ID

30082c0#diff-d83f728c5918299ec6f5a8d22447adb9fefac2726ab505dea12ba609dd79e068 ?

github-actions · 2024-04-30T06:21:50Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9924f99

freewheelssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:19:	MakeRequests	83.3%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:64:	MakeBids	95.2%
github.com/prebid/prebid-server/v2/adapters/freewheelssp/freewheelssp.go:109:	Builder		100.0%
total:										(statements)	90.2%

github-actions bot reviewed Apr 25, 2024

View reviewed changes

adapters/freewheelssp/freewheelssp.go Outdated Show resolved Hide resolved

github-actions bot reviewed Apr 25, 2024

View reviewed changes

adapters/freewheelssp/freewheelssp.go Outdated Show resolved Hide resolved

gargcreation1992 reviewed Apr 25, 2024

View reviewed changes

adapters/freewheelssp/freewheelssp.go Outdated Show resolved Hide resolved

gargcreation1992 reviewed Apr 25, 2024

View reviewed changes

adapters/freewheelssp/freewheelssp.go Outdated Show resolved Hide resolved

gargcreation1992 previously approved these changes Apr 25, 2024

View reviewed changes

gargcreation1992 assigned gargcreation1992 and Sonali-More-Xandr Apr 25, 2024

Sonali-More-Xandr reviewed Apr 25, 2024

View reviewed changes

static/bidder-info/default.profraw Outdated Show resolved Hide resolved

mwang-sticky dismissed gargcreation1992’s stale review via c385343 April 25, 2024 13:31

bsardo changed the title ~~freewheel-adapter: add video dur and cat~~ Freewheel: add video dur and cat Apr 25, 2024

gargcreation1992 reviewed Apr 29, 2024

View reviewed changes

adapters/freewheelssp/freewheelssp_test.go Outdated Show resolved Hide resolved

mwang-sticky force-pushed the freewheel-adapter branch from a26a598 to 37db0df Compare April 29, 2024 16:20

mwang-sticky added 5 commits April 30, 2024 14:20

freewheel-adapter: update video and type

bdafe49

simplify the name

ff59dec

modify according comment

4397ae9

remove typo

61830b1

udpate ut

9924f99

mwang-sticky force-pushed the freewheel-adapter branch from 37db0df to 9924f99 Compare April 30, 2024 06:21

gargcreation1992 approved these changes May 2, 2024

View reviewed changes

Sonali-More-Xandr approved these changes May 2, 2024

View reviewed changes

Sonali-More-Xandr merged commit 6520bac into prebid:master May 2, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request May 2, 2024

Port PR from PBS-Go: Freewheel: add video dur and cat prebid/prebid-server-java#3164

Closed

mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024

Freewheel: add video dur and cat (prebid#3640)

a406808

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Freewheel: add video dur and cat #3640

Freewheel: add video dur and cat #3640

mwang-sticky commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

github-actions bot commented Apr 29, 2024

gargcreation1992 commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

mwang-sticky commented Apr 29, 2024

github-actions bot commented Apr 30, 2024

Freewheel: add video dur and cat #3640

Freewheel: add video dur and cat #3640

Conversation

mwang-sticky commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Code coverage summary

freewheelssp

github-actions bot commented Apr 25, 2024

Code coverage summary

freewheelssp

github-actions bot commented Apr 25, 2024

Code coverage summary

freewheelssp

github-actions bot commented Apr 25, 2024

Code coverage summary

freewheelssp

github-actions bot commented Apr 29, 2024

Code coverage summary

freewheelssp

gargcreation1992 commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

Code coverage summary

freewheelssp

mwang-sticky commented Apr 29, 2024

github-actions bot commented Apr 30, 2024

Code coverage summary

freewheelssp