Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adkernel: bid.mtype support #3631

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Adkernel: bid.mtype support #3631

merged 3 commits into from
Apr 25, 2024

Conversation

ckbo3hrk
Copy link
Contributor

Support bid.mtype in order to simplify code #3390 (comment)

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 188b0e7

adkernel

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:32:	MakeRequests			70.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:64:	getImpressionsInfo		73.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:86:	validateImpression		66.7%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:94:	dispatchImpressions		100.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:114:	isMultiFormatImp		90.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:131:	splitMultiFormatImp		80.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:170:	getImpressionExt		71.4%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:186:	buildAdapterRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:210:	createBidRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:229:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:235:	MakeBids			78.9%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:275:	getMediaTypeForBid		83.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:290:	newBadInputError		0.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:296:	newBadServerResponseError	0.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:303:	Builder				100.0%
total:									(statements)			81.3%

onkarvhanumante
onkarvhanumante reviewed Apr 19, 2024
View reviewed changes
adapters/adkernel/adkernel.go Outdated
Comment on lines 285 to 286
default:
return openrtb_ext.BidTypeBanner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return error if no switch case matches

@ckbo3hrk
Update adkernel.go
07e4cfe 
code review fix
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 07e4cfe

adkernel

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:32:	MakeRequests			70.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:64:	getImpressionsInfo		73.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:86:	validateImpression		66.7%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:94:	dispatchImpressions		100.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:114:	isMultiFormatImp		90.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:131:	splitMultiFormatImp		80.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:170:	getImpressionExt		71.4%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:186:	buildAdapterRequest		83.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:210:	createBidRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:229:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:235:	MakeBids			77.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:279:	getMediaTypeForBid		83.3%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:296:	newBadInputError		0.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:302:	newBadServerResponseError	0.0%
github.com/prebid/prebid-server/v2/adapters/adkernel/adkernel.go:309:	Builder				100.0%
total:									(statements)			81.0%

@gargcreation1992 gargcreation1992 merged commit 78dd64d into prebid:master Apr 25, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Apr 25, 2024
Closed
mefjush pushed a commit to adhese/prebid-server that referenced this pull request Apr 25, 2024
@ckbo3hrk @mefjush
Adkernel: bid.mtype support (prebid#3631)
0fda2f3
@ckbo3hrk ckbo3hrk deleted the adkernel_bid_mtype branch April 25, 2024 14:02
@ckbo3hrk ckbo3hrk restored the adkernel_bid_mtype branch April 25, 2024 14:03
@ckbo3hrk ckbo3hrk deleted the adkernel_bid_mtype branch April 25, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@gargcreation1992 gargcreation1992

@onkarvhanumante onkarvhanumante

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckbo3hrk @gargcreation1992 @onkarvhanumante