Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartHub: add Markapp alias #3627

Merged
merged 1 commit into from
May 7, 2024

Conversation

SmartHubSolutions
Copy link
Contributor

No description provided.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 080a39e

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 330b442

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fa6d150

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 06d206e

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cc8d3d4

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

@bsardo bsardo changed the title Update SmartHub adapter and add Markapp alias SmartHub: add Markapp alias Apr 17, 2024
@bsardo bsardo changed the title SmartHub: add Markapp alias SmartHub: add audio and Markapp alias Apr 17, 2024
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6b84943

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 80afadb

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ebe3c6c

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3eb3ee3

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:29:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:42:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:60:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:69:	MakeRequests		86.7%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:105:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/smarthub/smarthub.go:181:	getBidType		100.0%
total:									(statements)		93.1%

endpoint: "http://{{.Host}}-prebid.smart-hub.io/?seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "http://prebid.smart-hub.io/pbserver?partnerName={{.Host}}&seat={{.AccountID}}&token={{.SourceId}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmartHubSolutions
endpoint is not reachable

curl -i --location --request POST 'http://prebid.smart-hub.io/pbserver/partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer'
curl: (7) Failed to connect to prebid.smart-hub.io port 80 after 295 ms: Couldn't connect to server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had some problems but from now on the server will be working 24/7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link must be ...pbserver?partnerName... instead wrong ...pbserver/partnerName...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

received 200 response

curl -i --location --request POST 'http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer'
HTTP/1.1 200 OK
Server: nginx

@onkarvhanumante onkarvhanumante changed the title SmartHub: add audio and Markapp alias SmartHub: add Markapp alias May 2, 2024
@onkarvhanumante onkarvhanumante merged commit 6cef5f9 into prebid:master May 7, 2024
5 checks passed
mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants