New Adapter: Admatic #3608

bakicam · 2024-04-04T09:55:39Z

We added s2s support for Admatic.

Docs PR: prebid/prebid.github.io#5232

adapters/admatic/admatic.go

github-actions · 2024-04-04T11:13:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, aaafa1f

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:35:	MakeRequests		68.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:76:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:95:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:111:	MakeBids		85.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:142:	getMediaTypeForBid	88.9%
total:									(statements)		77.4%

muuki88 · 2024-04-04T11:54:46Z

Docs: prebid/prebid.github.io#5232

static/bidder-info/admatic.yaml

github-actions · 2024-04-05T09:57:38Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1798069

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:35:	MakeRequests		68.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:76:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:95:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:111:	MakeBids		85.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:142:	getMediaTypeForBid	88.9%
total:									(statements)		77.4%

onkarvhanumante · 2024-04-05T10:36:22Z

@bakicam

consider syning Admatic-Sofware:master branch with prebid:master to resolve PR merge conflicts

adapters/admatic/admatic.go

adapters/admatic/admatic_test.go

onkarvhanumante · 2024-04-05T10:57:04Z

@bakicam should update json test

to have request with multiple imps
to have multi-format imp request
request with host set as imp ext param

github-actions · 2024-04-05T10:57:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1798069

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:35:	MakeRequests		68.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:76:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:95:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:111:	MakeBids		85.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:142:	getMediaTypeForBid	88.9%
total:									(statements)		77.4%

adapters/admatic/admatic.go

static/bidder-info/admatic.yaml

onkarvhanumante · 2024-04-05T11:15:38Z

@bakicam should create and link PR for bidder doc in https://github.com/prebid/prebid.github.io repository

bakicam · 2024-04-09T08:46:29Z

#3608 (comment)

Hello,
PR is here prebid/prebid.github.io#5232

github-actions · 2024-04-15T07:52:06Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2b85726

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:35:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:73:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:92:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:108:	MakeBids		86.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:141:	getMediaTypeForBid	88.9%
total:									(statements)		78.7%

onkarvhanumante · 2024-04-16T10:23:11Z

@bakicam PR has some merge conflicts. Requesting to resolve them.

farukcam · 2024-04-17T07:11:22Z

#3608 (comment) Hello, we have made arrangements for this.

farukcam · 2024-04-24T08:06:57Z

Hello,
Is there any progress regarding our request?

onkarvhanumante · 2024-04-25T06:08:11Z

Hello, Is there any progress regarding our request?

@bakicam requesting to push updates to resolve merge conflicts

github-actions · 2024-04-25T09:26:03Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f5014c6

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:35:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:73:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:92:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:108:	MakeBids		86.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:141:	getMediaTypeForBid	88.9%
total:									(statements)		78.7%

github-actions · 2024-04-25T09:34:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 821a9ff

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:35:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:73:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:92:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:108:	MakeBids		86.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:141:	getMediaTypeForBid	88.9%
total:									(statements)		78.7%

github-actions · 2024-04-25T09:37:41Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4544995

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:72:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:91:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:107:	MakeBids		86.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		78.7%

github-actions · 2024-04-25T09:46:28Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4ba7063

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:71:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:90:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:106:	MakeBids		86.7%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:139:	getMediaTypeForBid	88.9%
total:									(statements)		78.7%

github-actions · 2024-04-25T09:50:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1099844

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:71:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:90:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:106:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:132:	getMediaTypeForBid	88.9%
total:									(statements)		81.0%

bakicam · 2024-04-25T09:58:13Z

Hello, Is there any progress regarding our request?

@bakicam requesting to push updates to resolve merge conflicts

Hello,
We are currently just waiting for approval of SyntaxNode solutions. I would like you to check it.

farukcam · 2024-04-29T08:46:12Z

Hello,
We ask for your support

onkarvhanumante · 2024-05-02T07:12:50Z

@bakicam @farukcam PR has some merge conflicts. PTAL to resolve them. Requesting to sync Admatic-Sofware:master with prebid:master changes

farukcam · 2024-05-02T07:21:25Z

@onkarvhanumante I synced

farukcam · 2024-05-02T08:21:01Z

@onkarvhanumante @Sonali-More-Xandr Hello, I think there is a problem here. It has been merged but we cannot see the adapter.

onkarvhanumante · 2024-05-02T08:25:50Z

@farukcam changes force-pushed resulted into discarding file changes.

farukcam · 2024-05-02T08:27:00Z

@onkarvhanumante I'm so sorry, I think we made a mistake. Should we create a new job request?

onkarvhanumante · 2024-05-02T08:30:08Z

@onkarvhanumante I'm so sorry, I think we made a mistake. Should we create a new job request?

yes please create new PR

farukcam · 2024-05-02T08:31:04Z

@onkarvhanumante I request you to close this prebid/prebid-server-java#3165

onkarvhanumante · 2024-05-02T08:39:00Z

@onkarvhanumante I request you to close this prebid/prebid-server-java#3165

I don't have privledge to close PR from prebid-server-java repo. Added this prebid/prebid-server-java#3165 (comment) for closing PR.

farukcam · 2024-05-02T09:00:06Z

@onkarvhanumante Hello, We created a new application here #3654. Thank you for your support.

github-actions bot reviewed Apr 4, 2024

View reviewed changes

adapters/admatic/admatic.go Outdated Show resolved Hide resolved

muuki88 mentioned this pull request Apr 4, 2024

AdMatic: PBS support true prebid/prebid.github.io#5232

Merged

7 tasks

SyntaxNode requested changes Apr 5, 2024

View reviewed changes

static/bidder-info/admatic.yaml Outdated Show resolved Hide resolved

static/bidder-info/admatic.yaml Outdated Show resolved Hide resolved

gargcreation1992 assigned onkarvhanumante and Sonali-More-Xandr Apr 5, 2024

prebid deleted a comment from github-actions bot Apr 5, 2024