Local stored response fetching #3600
Conversation
zhongshixi
changed the title
|
cc @bretg for visibility |
| func (fetcher *eagerFetcher) FetchResponses(ctx context.Context, ids []string) (data map[string]json.RawMessage, errs []error) { | ||
| return nil, nil | ||
| storedResponses := fetcher.FileSystem.Directories["stored_responses"].Files |
There was a problem hiding this comment.
Per Gus suggestion, please use "data", not "storedResponses" #3326 (comment)
There was a problem hiding this comment.
@VeronikaSolovei9 @guscarreon
have updated the code implementation
|
cc @SyntaxNode for visibility & code review ( sorry i forgot to mention you) |
| @@ -35,8 +36,15 @@ func (fetcher *eagerFetcher) FetchRequests(ctx context.Context, requestIDs []str | |||
| return storedRequests, storedImpressions, errs | |||
| } | |||
|
|
|||
| // Fetch Responses - Implements the interface to read the stored response information from the fetcher's FileSystem, the directory name is "stored_responses" | |||
| func (fetcher *eagerFetcher) FetchResponses(ctx context.Context, ids []string) (data map[string]json.RawMessage, errs []error) { | |||
There was a problem hiding this comment.
Nitpick: what do you think about renaming fetcher here to just be f
There was a problem hiding this comment.
@AlexBVolcy i think that would be a different discussion, all the other fetchers, e.g http_fetcher, empty_fetcher and db_fetcherare all using the samefetcher` as the receiver name
| @@ -25,6 +27,55 @@ func TestFileFetcher(t *testing.T) { | |||
| validateImp(t, storedImps) | |||
| } | |||
|
|
|||
| func TestStoredResponseFileFetcher(t *testing.T) { | |||
|
|
|||
There was a problem hiding this comment.
Nitpick: Can you delete this space
@guscarreon
|
|
thanks @VeronikaSolovei9 for approval |
Problem
this PR is to unblock the hello world example framework i try to build