Fix: Use request alias as adaptercode #3587
Conversation
| @@ -379,14 +379,20 @@ func (bidder *bidderAdapter) requestBid(ctx context.Context, bidderRequest Bidde | |||
| } | |||
| } | |||
|
|
|||
| alternateBidderCode := "" | |||
| if !strings.EqualFold(bidderRequest.BidderName.String(), bidderName.String()) { | |||
There was a problem hiding this comment.
Is there a test in place where bidderRequest.BidderName is different from bidderName.string
I can't seem to find it, but just want to ensure we're testing the main case of this PR that you laid out.
There was a problem hiding this comment.
In case of aliase bidder its possible to have bidderRequest.BidderName is different that bidderName.
For example groupm is alias/alternate bidder code of pubmatic. So in this case bidderRequest.BidderName will be pubmatic and bidderName will be groupm. We are expecting adaptercode as pubmatic.
There was a problem hiding this comment.
I see, is it possible to add a json test of some kind where we can have this situation covered?
There was a problem hiding this comment.
@AlexBVolcy Added json test file alternate-bidder-codes-aliase.json
…ver into Fix_3363_adaptercode
bsardo
changed the title
…ver into Fix_3363_adaptercode
|
@Pubmatic-Supriya-Patil Hello! Just checking in to see if you've been able to see my feedback? |
|
Closing as this has been handled with a slightly different approach in #3661. |
This PR solves issue mentioned in #3363