Sonobi: Added consent macros to the user sync url #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonali-More-Xandr
approved these changes
Mar 18, 2024
gargcreation1992
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening this to pick the comment thread back up #3283
Pending open question:
Hey @onkarvhanumante, I reviewed this over with the team. The sync urls that fail to redirect is because the gdpr_consent string provided does not define that Sonobi is consented to user snyc. So, the endpoint will not redirect to the &loc query parameter.
Should our user sync endpoint redirect even if the gdpr_consent string doesnt say Sonobi is consented?