Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yandex: Fix yandex properties file #3568

Merged
merged 1 commit into from
Mar 18, 2024
Merged

yandex: Fix yandex properties file #3568

merged 1 commit into from
Mar 18, 2024

Conversation

gargcreation1992
Copy link
Contributor

OneOf cannot be used at properties level. This was overlooked during initial PR review. Issuing a quick fix here.

@gargcreation1992 gargcreation1992 changed the title Fix yandex properties file yandex: Fix yandex properties file Mar 12, 2024
@Sonali-More-Xandr Sonali-More-Xandr self-assigned this Mar 12, 2024
@chernodub
Copy link
Contributor

Hi @gargcreation1992 @Sonali-More-Xandr! Thanks for revisiting this!

I could not find anywhere in the docs that the previous implementation went against the json shema spec. Moreover, the validation worked as expected. I'd really appreciate it if you could point that out to me, thanks.

Overall, the change appears to be compatible with the previous one, so I think it's OK to merge this.

@gargcreation1992
Copy link
Contributor Author

Hi @gargcreation1992 @Sonali-More-Xandr! Thanks for revisiting this!

I could not find anywhere in the docs that the previous implementation went against the json shema spec.

Please refer to - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#bidder-parameters. Bidder params should be defined as properties and if there are any required fields then it should be under required key. Please also refer to examples provided there. Thanks!

@chernodub
Copy link
Contributor

Thank you kindly for pointing that out to me @gargcreation1992 and for making the update! Feel free to merge this 👍

@gargcreation1992 gargcreation1992 merged commit 82cb3e8 into master Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants