Fixed config parsing.

prebid · Oct 24, 2024 · c4b7cf5 · c4b7cf5
1 parent ceaeda1
commit c4b7cf5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/extra/modules/pb-request-correction/src/lombok.config b/extra/modules/pb-request-correction/src/lombok.config
@@ -0,0 +1 @@
+lombok.anyConstructor.addConstructorProperties = true
diff --git a/.../java/org/prebid/server/hooks/modules/pb/request/correction/core/config/model/Config.java b/.../java/org/prebid/server/hooks/modules/pb/request/correction/core/config/model/Config.java
@@ -4,8 +4,8 @@
 import lombok.Builder;
 import lombok.Value;
 
+@Value
 @Builder
-@Value(staticConstructor = "of")
 public class Config {
 
     boolean enabled;

diff --git a/...java/org/prebid/server/hooks/modules/pb/request/correction/core/util/VersionUtilTest.java b/...java/org/prebid/server/hooks/modules/pb/request/correction/core/util/VersionUtilTest.java
@@ -25,12 +25,6 @@ public void isVersionLessThenShouldReturnTrueIfVersionIsLessThanRequired() {
         assertThat(VersionUtil.isVersionLessThan("2.2.3", 2, 4, 3)).isTrue();
     }
 
-    @Test
-    public void isVersionLessThenShouldReturnFalseIfVersionIsUnparsable() {
-        // when and then
-        assertThat(VersionUtil.isVersionLessThan("2.2a.3", 2, 4, 3)).isFalse();
-    }
-
     @Test
     public void isVersionLessThenShouldReturnExpectedResults() {
         // major
@@ -40,8 +34,8 @@ public void isVersionLessThenShouldReturnExpectedResults() {
         assertThat(VersionUtil.isVersionLessThan("3", 2, 2, 3)).isFalse();
 
         // minor
-        assertThat(VersionUtil.isVersionLessThan("0" + MAX_VALUE, 2, 2, 3)).isTrue();
-        assertThat(VersionUtil.isVersionLessThan("1" + MAX_VALUE, 2, 2, 3)).isTrue();
+        assertThat(VersionUtil.isVersionLessThan("0." + MAX_VALUE, 2, 2, 3)).isTrue();
+        assertThat(VersionUtil.isVersionLessThan("1." + MAX_VALUE, 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("2.0", 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("2.1", 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("2.2", 2, 2, 3)).isTrue();
@@ -51,7 +45,7 @@ public void isVersionLessThenShouldReturnExpectedResults() {
         assertThat(VersionUtil.isVersionLessThan("0.%d.%d".formatted(MAX_VALUE, MAX_VALUE), 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("1.%d.%d".formatted(MAX_VALUE, MAX_VALUE), 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("2.1." + MAX_VALUE, 2, 2, 3)).isTrue();
-        assertThat(VersionUtil.isVersionLessThan("2.2.3", 2, 2, 3)).isTrue();
+        assertThat(VersionUtil.isVersionLessThan("2.2.1", 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("2.2.2", 2, 2, 3)).isTrue();
         assertThat(VersionUtil.isVersionLessThan("2.2.3", 2, 2, 3)).isFalse();
     }