Skip to content

Commit

Permalink
Github: Add Reviewer Checklist (#3520)
Browse files Browse the repository at this point in the history
  • Loading branch information
AntoxaAntoxic authored Oct 28, 2024
1 parent b5815fe commit 79669e6
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ What's the context for the changes? Are there any
Why did you choose to make these changes? Were there any trade-offs you had to consider?


### 🔎 New Bid Adapter Checklist
- [ ] verify email contact works
- [ ] NO fully dynamic hosts
- [ ] geographic host parameters are NOT required
- [ ] NO direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job*
- [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - *define the new adapter as the alias of the generic adapter*
- [ ] cover an adapter configuration with an integration test


### 🧪 Test plan

How do you know the changes are safe to ship to production?
Expand Down

0 comments on commit 79669e6

Please sign in to comment.