Silence the programatic critics. (#459)

prebid · Jul 20, 2016 · 83af15a · 83af15a
1 parent ccf441e
commit 83af15a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/src/adapters/aardvark.js b/src/adapters/aardvark.js
@@ -19,12 +19,12 @@ var AardvarkAdapter = function AardvarkAdapter() {
   }
 
   function _requestBids(bidReqs) {
-
+    let ref;
     try {
-      var ref = window.top.location.host;
+      ref = window.top.location.host;
     }
     catch (err) {
-      var ref = "thor.rtk.io";
+      ref = "thor.rtk.io";
 
     }
     var ai = "";

diff --git a/src/adapters/nginad.js b/src/adapters/nginad.js
@@ -142,6 +142,7 @@ var NginAdAdapter = function NginAdAdapter() {
       var id = nginadBid.impid;
 
       // try to fetch the bid request we sent NginAd
+      /*jshint -W083 */
       var bidObj = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === 'nginad').bids
         .find(bid => bid.bidId === id);
       if (!bidObj) {

diff --git a/src/adapters/sonobi.js b/src/adapters/sonobi.js
@@ -33,13 +33,14 @@ var SonobiAdapter = function SonobiAdapter(){
         case (!!o.params.placement_id && o.params.placement_id.length === 0):
           utils.logError('Sonobi unable to bid: Empty placement_id for ' + o.placementCode);
           break;
-        case (!!o.params.placement_id):     //  Morpeus style 
+        case (!!o.params.placement_id):     //  Morpeus style
           keyring[o.params.dom_id] = o.params.placement_id + (test ? '-test' : '')  + '|' + sizes;
           cb_map[o.params.dom_id] = o.placementCode;
           break;
         case (!!o.params.ad_unit && o.params.ad_unit.charAt(0) !== '/'):
           //  DFP docs do not necessarily require leading slash? - add it in if it's not there.
           o.params.ad_unit = '/' + o.params.ad_unit;
+          /* falls through */
         case (!!o.params.ad_unit):          // Cypher style
           keyring[o.params.ad_unit + '|' + o.params.dom_id] = sizes;
           cb_map[o.params.ad_unit + '|' + o.params.dom_id] = o.placementCode;
@@ -88,4 +89,4 @@ var SonobiAdapter = function SonobiAdapter(){
   return { callBids: _phone_in };
 };
 
-module.exports = SonobiAdapter;
+module.exports = SonobiAdapter;
diff --git a/src/adapters/sovrn.js b/src/adapters/sovrn.js
@@ -72,7 +72,7 @@ var SovrnAdapter = function SovrnAdapter() {
   }
 
   function addBlankBidResponses(impidsWithBidBack) {
-    var missing = pbjs._bidsRequested.find(bidSet => bidSet.bidderCode === 'sovrn').bids
+    var missing = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === 'sovrn').bids
       .filter(bid => impidsWithBidBack.indexOf(bid.bidId) < 0);
 
     missing.forEach(function (bidRequest) {

diff --git a/src/polyfill.js b/src/polyfill.js
@@ -1,7 +1,7 @@
 /** @module polyfill
 Misc polyfills
 */
-
+/*jshint -W121 */
 if (!Array.prototype.find) {
   Array.prototype.find = function(predicate) {
     if (this === null) {