Revert "Fix maxp table" #104
Open
+17
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsrennebarth
suggested changes
Jun 25, 2024
There was a problem hiding this comment.
Yes, this fixes the Adobe Reader warnings "Cannot extract embedded font xxx" when viewing a PDF generated with prawn 2.4.0
I am well aware that reverting this change to the encode function is not a real fix, but the current encode function just does not work so we better get back to the old function that does work.
|
Thank you for developing such a wonderful gem. Is there any issue preventing this PR from being merged? I’m experiencing the same issue in my environment, and I would love to update the TTFunk version if this could be merged. It would be greatly appreciated. |
|
@hayaokimura Lack of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ttfunk v1.8.0, using Japanese true type fonts such as GenShin Gothic resulted in creating PDF files that could not be loaded in Acrobat Reader. The cause seems to be with maxp, and by applying a monkey patch to make the code equivalent to ttfunk v1.7.0, normal PDFs were able to be generated. So I would like to revert the relevant code. If I revert the pull request #78, the ChangeLog and others would also be reverted, so I reverted only the code to be the same as ttfunk v1.7.0. Issue #102 likely has the same root cause.