Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-589-Added imagepullsecrets for both helm hooks in zk-operator charts #590

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krishnadas-menon
Copy link

Change log description

Currently the helm hooks used in zookeeper operator doesn't provide a mechanism to add imagepullsecrets to pull images from private registry.
The PR could help us to override this limitation.

Purpose of the change

Fixes #589

What the code does

The code snippet will render the imagepull secrets added in either global section OR under hooks.serviceAccount.imagePullSecrets in values file.

How to verify it

## Create a secret in the desired namespace
kubectl create secret docker-registry  registry-name --docker-username=<username> --docker-password=<password> --namespace=zk-operator
helm upgrade --install zk <chartPath> -n zk-operator --create-namespace --set hooks.serviceAccount.imagePullSecrets={'registry-name'} --set global.imagePullSecrets={'registry-name'} --atomic

## OR

helm template zookeeper . -s templates/post-install-upgrade-hooks.yaml --namespace=zk-operator --set hooks.serviceAccount.imagePullSecrets={'regsitry-name'}
helm template zookeeper . -s templates/pre-delete-hooks.yaml --namespace=zk-operator --set hooks.serviceAccount.imagePullSecrets={'regsitry-name'}

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fc6151) 85.91% compared to head (d0d1e80) 85.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files          12       12           
  Lines        1633     1633           
=======================================
  Hits         1403     1403           
  Misses        145      145           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add imagePullSecrets to Helm Hooks in Zookeeper_Operator charts
1 participant