Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets to Helm Hooks in Zookeeper_Operator charts #589

Closed
krishnadas-menon opened this issue Jan 22, 2024 · 0 comments · Fixed by #591 · May be fixed by #590
Closed

Add imagePullSecrets to Helm Hooks in Zookeeper_Operator charts #589

krishnadas-menon opened this issue Jan 22, 2024 · 0 comments · Fixed by #591 · May be fixed by #590

Comments

@krishnadas-menon
Copy link

krishnadas-menon commented Jan 22, 2024

Description

Currently the service accounts/Job definitions of Zookeeper-Operator Helm hooks doesn't have a way to incorporate the imagepull secrets.

Importance

MustHave

Location

https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/pre-delete-hooks.yaml#L39-L47
https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/pre-delete-hooks.yaml#L39-L47

Suggestions for an improvement

Will try to add the global.imagePullSecrets or hooks.serviceAccount.imagePullSecrets section under serviceaccount for hooks

@krishnadas-menon krishnadas-menon changed the title Add imagePullSecrets to Helm Hooks in Zookeeper_Operator Add imagePullSecrets to Helm Hooks in Zookeeper_Operator charts Jan 22, 2024
unguiculus pushed a commit to unguiculus/zookeeper-operator that referenced this issue Jan 22, 2024
### Change log description

* Adds imagePullSecrets to the service accounts for the Helm hooks
* Follows the same principle as the service account for the operator
  taking global imagePullSecrets into account

### Purpose of the change

Fixes pravega#589

### What the code does

Adds imagePullSecrets to the YAML for the ServiceAccounts for the Helm
hooks. This is important when images are pulled from a private registry,
e.g. an internal proxy, such as Artifactory, or when using cusom images.

### How to verify it

Render the tem plates using the following commands:

```console
helm template zookeeper charts/zookeeper-operator \
    --show-only templates/post-install-upgrade-hooks.yaml \
    --show-only templates/pre-delete-hooks.yaml \
    --set hooks.serviceAccount.imagePullSecrets={'my-pull-secret'}
```

Signed-off-by: Reinhard Nägele <[email protected]>

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Author:    Krishnadas Menon <[email protected]>
# Date:      Mon Jan 22 14:32:23 2024 +0530
#
# On branch issue-589-pull-creds-for-hook
# Changes to be committed:
#	modified:   charts/zookeeper-operator/templates/post-install-upgrade-hooks.yaml
#	modified:   charts/zookeeper-operator/templates/pre-delete-hooks.yaml
#	modified:   charts/zookeeper-operator/values.yaml
#
unguiculus pushed a commit to unguiculus/zookeeper-operator that referenced this issue Jan 22, 2024
* Adds imagePullSecrets to the service accounts for the Helm hooks
* Follows the same principle as the service account for the operator
  taking global imagePullSecrets into account

Fixes pravega#589

Adds imagePullSecrets to the YAML for the ServiceAccounts for the Helm
hooks. This is important when images are pulled from a private registry,
e.g. an internal proxy, such as Artifactory, or when using custom images.

Render the tem plates using the following commands:

```console
helm template zookeeper charts/zookeeper-operator \
    --show-only templates/post-install-upgrade-hooks.yaml \
    --show-only templates/pre-delete-hooks.yaml \
    --set hooks.serviceAccount.imagePullSecrets={'my-pull-secret'}
```

Signed-off-by: Reinhard Nägele <[email protected]>
unguiculus pushed a commit to unguiculus/zookeeper-operator that referenced this issue Jan 22, 2024
### Change log description

* Adds imagePullSecrets to the service accounts for the Helm hooks
* Follows the same principle as the service account for the operator
  taking global imagePullSecrets into account

### Purpose of the change

Fixes pravega#589

### What the code does

Adds imagePullSecrets to the YAML for the ServiceAccounts for the Helm
hooks. This is important when images are pulled from a private registry,
e.g. an internal proxy, such as Artifactory, or when using custom images.

### How to verify it

Render the templates using the following command:

```console
helm template zookeeper charts/zookeeper-operator \
    --show-only templates/post-install-upgrade-hooks.yaml \
    --show-only templates/pre-delete-hooks.yaml \
    --set hooks.serviceAccount.imagePullSecrets={'my-pull-secret'}
```

Signed-off-by: Reinhard Nägele <[email protected]>

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Mon Jan 22 11:52:54 2024 +0100
#
# On branch issue-589-pull-creds-for-hook
# Your branch and 'origin/issue-589-pull-creds-for-hook' have diverged,
# and have 1 and 1 different commits each, respectively.
#
# Changes to be committed:
#	modified:   charts/zookeeper-operator/templates/post-install-upgrade-hooks.yaml
#	modified:   charts/zookeeper-operator/templates/pre-delete-hooks.yaml
#	modified:   charts/zookeeper-operator/values.yaml
#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant