-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-transactional write. #35
Support for non-transactional write. #35
Conversation
Signed-off-by: Bhupender Y <[email protected]>
Signed-off-by: Bhupender Y <[email protected]>
Signed-off-by: Bhupender Y <[email protected]>
…upport-non-txn-write
Signed-off-by: Bhupender Y <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. Elaborated description might help to understand the context.
I assume post changes below scenarios are validated.
- Raw file with size more than 8mb
- Raw file with size less than 8mb
if(writer.getTransactionStatus() == Transaction.Status.OPEN){ | ||
writer.abort(); | ||
if (config.exactlyOnce) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Bhupender Y <[email protected]>
Signed-off-by: Bhupender Y <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Let's test it thoroughly before merging
Signed-off-by: Bhupender Y <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bhupender Y <[email protected]>
13d830f
into
pravega:stability-improvements-v2
Use non-transactional write processing raw files. In the current scenario for raw files PSC is using transactional write. But in transactional write, there is a limit of event size i.e 8mb. To resolve it out, for raw files processing instead of using transactional writer, it will use non-transactional writer.