Issue 16 : API for list scope and list stream #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anju_das <[email protected]>
for build test
Signed-off-by: anju_das <[email protected]>
Trigger Build
Signed-off-by: anju_das <[email protected]>
Trigger Build
Signed-off-by: anju_das <[email protected]>
Trigger Build
Signed-off-by: anju_das <[email protected]>
Trigger Build
Signed-off-by: anju_das <[email protected]>
Trigger Build
Signed-off-by: anju_das <[email protected]>
Trigger Build
Signed-off-by: anju_das <[email protected]>
for build test
Signed-off-by: anju_das <[email protected]>
Signed-off-by: anju_das <[email protected]>
Signed-off-by: anju_das <[email protected]>
anju-c-das
requested review from
AnkurAnand11,
Bhupender-Y,
tkaitchuck and
ShwethaSNayak
anju-c-das
changed the title
Bhupender-Y
reviewed
Feb 2, 2024
tests/pravega_client_test.py
Outdated
| @@ -57,6 +58,23 @@ def test_tags(self): | |||
| tags = stream_manager.get_stream_tags(scope, "testStream1") | |||
| self.assertEqual(["t4", "t5"], tags) | |||
|
|
|||
| # test for list_scope api | |||
| scope_list = stream_manager.list_scope() | |||
| self.assertTrue(len(scope_list) > 0, "The list is empty") | |||
There was a problem hiding this comment.
Instead of scope_list > 0, can we update the assert to length equal to 1.
There was a problem hiding this comment.
As we checked offline, it can't be updated with length equal to 1, as it retains all the scope that exist in standalone run too.
So it may or may not be always 1.
tkaitchuck
requested changes
Feb 2, 2024
| Ok(scoped_stream) => { | ||
| stream_vector_act.push(scoped_stream.stream.name) | ||
| }, | ||
| Err(e) => { |
There was a problem hiding this comment.
Same here.
It may be useful to have a private method so as to not duplicate so much
Signed-off-by: anju_das <[email protected]>
tkaitchuck
approved these changes
Feb 6, 2024
AnkurAnand11
approved these changes
Feb 6, 2024
Signed-off-by: anju_das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Add new API to get list of scope and list of stream for python client.
Purpose of the change
Fixes #19
What the code does
The code has two new APi's list_scope and list_stream which when called will return the list of scope and list of stream respectively.
How to verify it
Test cases should pass.