-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-668] Manage all the source and sink configurations in Flink ConfigOptions #670
Open
thekingofcity
wants to merge
9
commits into
pravega:master
Choose a base branch
from
thekingofcity:issue-668-Manage-all-the-source-and-sink-configurations-in-Flink-ConfigOptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thekingofcity <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
============================================
- Coverage 82.62% 81.92% -0.71%
- Complexity 574 588 +14
============================================
Files 60 62 +2
Lines 2677 2877 +200
Branches 226 238 +12
============================================
+ Hits 2212 2357 +145
- Misses 291 339 +48
- Partials 174 181 +7
Continue to review full report at Codecov.
|
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
crazyzhou
requested changes
Apr 12, 2022
src/main/java/io/pravega/connectors/flink/config/PravegaClientConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/source/PravegaSourceBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/config/PravegaClientConfigBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/config/PravegaClientConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/config/PravegaClientConfigBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/config/PravegaClientConfigBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/source/PravegaSourceOptions.java
Show resolved
Hide resolved
src/test/java/io/pravega/connectors/flink/source/FlinkPravegaSourceITCase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
…onfigurations-in-Flink-ConfigOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: thekingofcity [email protected]
Change log description
It could be better if we have a central place to store all the client configurations, but now we are separating them in each of the source/sink builder.
This is not an ideal way because these configurations are not clearly exposed to the end users.
Purpose of the change
Fix #668
What the code does
Use a new
PravegaOptions
to set and get Pravega client config.How to verify it
.\gradlew clean build
should pass.