Minor optimizations + title feature #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the element. (Only happens the first time we wipe the original text, and only if a 'title' wasn't already set). This allows your original HTML (before JS runs) to have a human readable date like "April 11, 2014" and then have smart-time-ago make it say "1 month ago" but then the user can still hover their mouse to see the more detailed/accurate format of the date. <time class="timeago" datetime="2014-04-11">April 11, 2014</time> Of course, a tooltip could be done already without these changes if you make the original HTML like this: <time class="timeago" datetime="2014-04-11" title="April 11, 2014">April 11, 2014</time> However having the 'title' before the text has changed is redundant, and not in the spirit of JS gracefully enhancing the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want only some of these commits, feel free to cherry-pick them (e.g. if you want to build it yourself)