Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo consistency #639

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

Repo consistency #639

wants to merge 43 commits into from
+1,921 −298

Commits on Oct 17, 2024

  1. Need to merge develop back in

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9126a9f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into repo-consistency

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d47888e View commit details
    Browse the repository at this point in the history

  3. Added direct git install for iso639

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6f9842a View commit details
    Browse the repository at this point in the history

  4. Perparing to remove pip

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9996a04 View commit details
    Browse the repository at this point in the history

  5. Unpinned versions

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a45b777 View commit details
    Browse the repository at this point in the history

  6. Pinned specific 'rapidpro-python' version

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    904614d View commit details
    Browse the repository at this point in the history

  7. Added blanket ignores until ruff throws no errors

    @fritzbrand
    fritzbrand committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5a88fc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Redefinition of unused and ruff format

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a9f57f1 View commit details
    Browse the repository at this point in the history

  2. Use 'enumerate()' for index variable 'total' in 'for' loop

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    346e40f View commit details
    Browse the repository at this point in the history

  3. Use ternary operator instead of 'if'-'else'-block

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a7c53c2 View commit details
    Browse the repository at this point in the history

  4. Return the condition 'label in labels' directly

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3d470a6 View commit details
    Browse the repository at this point in the history

  5. 'typing.Text' is deprecated, use 'str'

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    95a413f View commit details
    Browse the repository at this point in the history

  6. Unnecessary 'map' usage (rewrite using a generator expression)

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4fd7bd View commit details
    Browse the repository at this point in the history

  7. Do not use mutable data structures for argument defaults

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a4e5d64 View commit details
    Browse the repository at this point in the history

  8. Found useless expression. Either assign it to a variable or remove it.

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    570704f View commit details
    Browse the repository at this point in the history

  9. Possible hardcoded password assigned

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d982515 View commit details
    Browse the repository at this point in the history

  10. Unnecessary imports for target Python version

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    721c825 View commit details
    Browse the repository at this point in the history

  11. Within an 'except' clause, raise exceptions with 'raise ... from err'… 

    … or 'raise ... from None'
    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    462ce1b View commit details
    Browse the repository at this point in the history

  12. Standard pseudo-random generators are not suitable for cryptographic … 

    …purposes
    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3fb00c5 View commit details
    Browse the repository at this point in the history

  13. Use 'super()' instead of 'super(__class__, self)'

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fed49a6 View commit details
    Browse the repository at this point in the history

  14. Use format specifiers instead of percent format

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ac1974f View commit details
    Browse the repository at this point in the history

  15. 'try'-'except'-'continue' detected, consider logging the exception

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    61b890a View commit details
    Browse the repository at this point in the history

  16. Use 'contextlib.suppress(Exception)' instead of 'try'-'except'-'pass'

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    13ec3dd View commit details
    Browse the repository at this point in the history

  17. Use a single 'if' statement instead of nested 'if' statements

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    340904e View commit details
    Browse the repository at this point in the history

  18. Use 'is' and 'is not' for type comparisons, or 'isinstance()' for isi… 

    …nstance checks
    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3072035 View commit details
    Browse the repository at this point in the history

  19. Use 'return any(post in group[name].lower() for group in contact[grou… 

    …ps])' instead of 'for' loop
    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7bd8a0f View commit details
    Browse the repository at this point in the history

  20. 'try'-'except'-'pass' detected, consider logging the exception

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1f1eb00 View commit details
    Browse the repository at this point in the history

  21. Possible hardcoded password assigned to argument

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    143e247 View commit details
    Browse the repository at this point in the history

  22. Loop control variable 'status_code' not used within loop body

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4e40d3 View commit details
    Browse the repository at this point in the history

  23. Class 'Template' inherits from 'object'

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4f8c9a9 View commit details
    Browse the repository at this point in the history

  24. Unnecessary 'list' comprehension (rewrite using 'list()')

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2febd39 View commit details
    Browse the repository at this point in the history

  25. Use implicit references for positional format fields

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    94575cd View commit details
    Browse the repository at this point in the history

  26. 'open()' should be replaced by 'Path.open()' maybe use pathlib

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0c5fa39 View commit details
    Browse the repository at this point in the history

  27. Use f-string instead of 'format' call

    @fritzbrand
    fritzbrand committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9a93005 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. GitHub Actions update

    @fritzbrand
    fritzbrand committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fd2c60f View commit details
    Browse the repository at this point in the history

  2. Update Dockerfile

    @fritzbrand
    fritzbrand committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3b2c0bc View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Update merge conflicts

    @fritzbrand
    fritzbrand committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9b2034b View commit details
    Browse the repository at this point in the history

  2. Removed setup.py and updated test.yaml

    @fritzbrand
    fritzbrand committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    958975e View commit details
    Browse the repository at this point in the history

  3. Removed global S106 ignore, and added inline ignores

    @fritzbrand
    fritzbrand committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5b2d52d View commit details
    Browse the repository at this point in the history

  4. RUF - enabled ruff-specific rules

    @fritzbrand
    fritzbrand committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7d8bc10 View commit details
    Browse the repository at this point in the history

  5. Formatting

    @fritzbrand
    fritzbrand committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e54ac24 View commit details
    Browse the repository at this point in the history

  6. Updated wording for S106 inlines

    @fritzbrand
    fritzbrand committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    165fac8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Updates after feedback

    @fritzbrand
    fritzbrand committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f54b07e View commit details
    Browse the repository at this point in the history