Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion marker to daily challenge profile counter #31543

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jan 17, 2025

Recommend reviewing with whitespace off.


osu_2025-01-17_10-39-39

Displays only on your own profile if you've played daily challenge today.

bdach added 2 commits January 17, 2025 10:26
It was clipping the daily challenge completion checkmark, and it
originates in some veeeeery old code where the profile overlay looked
and behaved very differently (0fa0271).
@peppy peppy self-requested a review January 20, 2025 06:14
@peppy peppy merged commit c20b836 into ppy:master Jan 20, 2025
9 of 10 checks passed
@bdach bdach deleted the daily-challenge-completion-marker branch January 20, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Played variant for daily challenge counter
2 participants