Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UserRankPanel rank overflowing on 6+ digits #30433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix UserRankPanel rank overflowing on 6+ digits #30433

wants to merge 1 commit into from

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Oct 27, 2024 •
edited by frenzibyte
Loading

@bdach
Copy link
Collaborator

bdach commented Oct 28, 2024

cc @ppy/team-design

@cl8n
Copy link
Member

cl8n commented Oct 29, 2024

yeah that's fine for now. we're working on a user card update to address other feedback lately so will keep this in mind to avoid similar issues

bdach
bdach approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like an acceptable stopgap

@bdach bdach requested a review from peppy November 1, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

@peppy peppy Awaiting requested review from peppy

Assignees
No one assigned
Labels
area:toolbar size/S type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expanded local user card from toolbar overflows at 7 digits and/or language-based wide spaces
4 participants
@stanriders @bdach @cl8n @frenzibyte