Fix multiplayer song select not correctly applying filter sometimes #30425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the root client-side failure causing ppy#30415. Thread of breakage is as follows: 1. `SongSelect` loads the carousel. At this point, the ruleset is what the ambient ruleset would have been at the time of pushing song select, so most likely it will match the current ruleset. Notably, the carousel is loaded with `AllowSelection == false`. 2. `OnlinePlaySongSelect` sets the ruleset to the one taken from the relevant playlist item in `LoadComplete()`. 3. At any point between the previous and the next step, the user changes the ruleset manually. 4. `SongSelect.carouselBeatmapsLoaded()` is ran, which calls `transferRulesetValue()`, which calls `FilterControl.FilterChanged`. But at this stage `Carousel.AllowSelection` is still false, so the filter is not executed, but `pendingFilterApplication` is set instead. Unfortunately, the pending filter never gets applied after that. The only place that checks that flag is `OnEntering()`, which at this point has already ran. To fix, move the `pendingFilterApplication` check to `Update()`, which seems like the most obvious and safe solution.
bdach
added
area:song-select
area:multiplayer
next release
|
FWIW, I wouldn't be surprised if this happens to fix #29751 too. |
Doesn't seem to fix that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Fixes the root client-side failure causing #30415.
Thread of breakage is as follows:
SongSelectloads the carousel. At this point, the ruleset is what the ambient ruleset would have been at the time of pushing song select, so most likely it will match the current ruleset. Notably, the carousel is loaded withAllowSelection == false.OnlinePlaySongSelectsets the ruleset to the one taken from the relevant playlist item inLoadComplete().SongSelect.carouselBeatmapsLoaded()is ran, which callstransferRulesetValue(), which callsFilterControl.FilterChanged. But at this stageCarousel.AllowSelectionis still false, so the filter is not executed, butpendingFilterApplicationis set instead. Unfortunately, the pending filter never gets applied after that. The only place that checks that flag isOnEntering(), which at this point has already ran.To fix, move the
pendingFilterApplicationcheck toUpdate(), which seems like the most obvious and safe solution.