Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notification text when import is paused due to gameplay #30402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −10

Make flow more `async` to avoid any chance of deadlocks

61f0cfd
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Update notification text when import is paused due to gameplay #30402

Make flow more `async` to avoid any chance of deadlocks
61f0cfd
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed Oct 24, 2024 in 1s

10683 passed, 2 failed and 74 skipped

Tests failed

❌ TestResults-Windows-SingleThread.trx

10759 tests were completed in 2369s with 10683 passed, 2 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Online.TestSceneReplayMissingBeatmap 4✅ 2❌ 23s

❌ osu.Game.Tests.Visual.Online.TestSceneReplayMissingBeatmap

✅ TestConstructor
✅ TestConstructor
❌ TestSceneMissingBeatmapWithOnlineAvailable
	"Replay missing notification show" timed out
❌ TestSceneMissingBeatmapWithOnlineAvailable
	"Replay missing notification show" timed out
✅ TestSceneMissingBeatmapWithOnlineUnavailable
✅ TestSceneMissingBeatmapWithOnlineUnavailable

Annotations

Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Online.TestSceneReplayMissingBeatmap ► TestSceneMissingBeatmapWithOnlineAvailable 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "Replay missing notification show" timed out
Raw output 
"Replay missing notification show" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Online.TestSceneReplayMissingBeatmap ► TestSceneMissingBeatmapWithOnlineAvailable 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "Replay missing notification show" timed out
Raw output 
"Replay missing notification show" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
View more details on GitHub Actions