Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow viewing bookmarks in Editor #28810

Closed
wants to merge 10 commits into from
Closed

Allow viewing bookmarks in Editor #28810

wants to merge 10 commits into from

Conversation

Peter-io
Copy link

Preview:

osu.2024.07.10.-.19.52.05.01.mp4
  • Kept bookmarks as array in the end since this pr doesn't allow adding new ones just viewing.

@bdach
Copy link
Collaborator

bdach commented Jul 10, 2024 •
edited
Loading

This is basically #28473 / #23418 but worse than those two because it only makes bookmarks work rather than addressing the underlying issue.

I don't see the point of having this open when the two other PRs are there.

@Peter-io
Copy link
Author

okay i will close it then

@Peter-io Peter-io closed this Jul 10, 2024
@Peter-io Peter-io deleted the editor-bookmarks branch July 10, 2024 18:51
@frenzibyte frenzibyte mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peter-io @bdach