Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded local user card from toolbar overflows at 7 digits and/or language-based wide spaces #27296

Open
Tracked by #3504
HastagGuigui opened this issue Feb 21, 2024 · 3 comments · May be fixed by #30433
Open
Tracked by #3504

Expanded local user card from toolbar overflows at 7 digits and/or language-based wide spaces #27296

HastagGuigui opened this issue Feb 21, 2024 · 3 comments · May be fixed by #30433
Labels
type:cosmetic

Comments

@HastagGuigui
Copy link

Type

Cosmetic

Bug description

If you look at your player card while playing in french, the spaces may overflow the rank text.
It is to note that this only happen in french, as every other language that uses spaces (screenshot 2, Česky) seem to use a different kind of space.
Overall, if you're a 7-digit (rank 1 000 000 and higher), the space for the rank on your profile card seems a bit small.

Screenshots or videos

image
image
image

Version

2024.219.0

Logs

compressed-logs.zip
@frenzibyte
Copy link
Member

It's already looking bad on English with 7 digits. Needs reconsideration.

@frenzibyte frenzibyte changed the title Rank on player card overflowing in French, and overall French using a different kind of space to separate numbers than other languages Expanded local user card from toolbar overflows at 7 digits and/or language-based wide spaces Feb 22, 2024
@bdach
Copy link
Collaborator

bdach commented Feb 22, 2024

See also: #27147 (comment)

@Joehuu
Copy link
Member

Joehuu commented Feb 23, 2024 •
edited
Loading

I think truncating the rank (i.e. 1.03M with the images above) and showing the exact one with a tooltip would be another solution if we don't want to increase the width.

We have results screen doing that for no reason (there's a lot of width here):
osu!_4uAaOxg7BP

Or just remove the padding from the left. It's smaller in the figma designs because it's dependant on the avatar width.

@frenzibyte frenzibyte mentioned this issue Mar 17, 2024
Closed
@Joehuu Joehuu mentioned this issue Oct 9, 2024
Open
@frenzibyte frenzibyte linked a pull request Oct 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UserRankPanel rank overflowing on 6+ digits stanriders/osu
4 participants
@bdach @frenzibyte @Joehuu @HastagGuigui