Skip to content
Back to pull request #30314

Refactor to command pattern for change handling V2 #22229

Sign in to view logs

Refactor to command pattern for change handling V2

Refactor to command pattern for change handling V2 #22229

Triggered via pull request October 19, 2024 15:45
@OliBombyOliBomby
synchronize #30314
OliBomby:command-pattern-real-3
Status Failure
Total duration 55m 6s
Artifacts 4

ci.yml

on: pull_request
Code Quality
11m 26s
Code Quality
Build only (Android)
11m 18s
Build only (Android)
Build only (iOS)
3m 57s
Build only (iOS)
Matrix: Test
Fit to window
Zoom out
Zoom in

Annotations

48 errors and 5 warnings
Test (Linux, ubuntu-latest, SingleThread)
Process completed with exit code 1.
Test (Linux, ubuntu-latest, MultiThreaded)
Process completed with exit code 1.
Test (Windows, windows-latest, SingleThread)
Process completed with exit code 1.
Test (Windows, windows-latest, MultiThreaded)
Process completed with exit code 1.
osu.Game.Rulesets.Mania.Tests.Editor.TestSceneEditor ► TestReloadOnBPMChange: osu.Game/Tests/Visual/OsuTestScene.cs#L541
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: "composer reloaded" timed out
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestMergeCircleSlider: TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestSimpleMerge: TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(BSpline): TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Catmull): TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Linear): TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(PerfectCurve): TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderVelocityAdjust ► TestVelocityUndo: osu.Game.Rulesets.Osu.Tests/Editor/TestSceneSliderVelocityAdjust.cs#L130
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Windows-MultiThreaded.trx#L0
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectThenUndoThenRedo: osu.Game.Tests/Visual/Editing/TestSceneEditorChangeStates.cs#L104
Failed test found in: TestResults-Windows-MultiThreaded.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Rulesets.Mania.Tests.Editor.TestSceneEditor ► TestReloadOnBPMChange: osu.Game/Tests/Visual/OsuTestScene.cs#L541
Failed test found in: TestResults-Windows-SingleThread.trx Error: "composer reloaded" timed out
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestMergeCircleSlider: TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestSimpleMerge: TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(BSpline): TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Catmull): TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Linear): TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(PerfectCurve): TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderVelocityAdjust ► TestVelocityUndo: osu.Game.Rulesets.Osu.Tests/Editor/TestSceneSliderVelocityAdjust.cs#L130
Failed test found in: TestResults-Windows-SingleThread.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Windows-SingleThread.trx#L0
Failed test found in: TestResults-Windows-SingleThread.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectThenUndoThenRedo: osu.Game.Tests/Visual/Editing/TestSceneEditorChangeStates.cs#L104
Failed test found in: TestResults-Windows-SingleThread.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Rulesets.Mania.Tests.Editor.TestSceneEditor ► TestReloadOnBPMChange: osu.Game/Tests/Visual/OsuTestScene.cs#L541
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: "composer reloaded" timed out
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestMergeCircleSlider: TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestSimpleMerge: TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(BSpline): TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Catmull): TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Linear): TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(PerfectCurve): TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderVelocityAdjust ► TestVelocityUndo: osu.Game.Rulesets.Osu.Tests/Editor/TestSceneSliderVelocityAdjust.cs#L130
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Linux-MultiThreaded.trx#L0
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectThenUndoThenRedo: osu.Game.Tests/Visual/Editing/TestSceneEditorChangeStates.cs#L104
Failed test found in: TestResults-Linux-MultiThreaded.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Rulesets.Mania.Tests.Editor.TestSceneEditor ► TestReloadOnBPMChange: osu.Game/Tests/Visual/OsuTestScene.cs#L541
Failed test found in: TestResults-Linux-SingleThread.trx Error: "composer reloaded" timed out
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestMergeCircleSlider: TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneObjectMerging ► TestSimpleMerge: TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: merged objects restored
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(BSpline): TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Catmull): TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(Linear): TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderChangeStates ► TestSliderRetainsCurveTypes(PerfectCurve): TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: slider not removed
osu.Game.Rulesets.Osu.Tests.Editor.TestSceneSliderVelocityAdjust ► TestVelocityUndo: osu.Game.Rulesets.Osu.Tests/Editor/TestSceneSliderVelocityAdjust.cs#L130
Failed test found in: TestResults-Linux-SingleThread.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectAndUndo: TestResults-Linux-SingleThread.trx#L0
Failed test found in: TestResults-Linux-SingleThread.trx Error: hitobject removed
osu.Game.Tests.Visual.Editing.TestSceneEditorChangeStates ► TestAddObjectThenUndoThenRedo: osu.Game.Tests/Visual/Editing/TestSceneEditorChangeStates.cs#L104
Failed test found in: TestResults-Linux-SingleThread.trx Error: System.NullReferenceException : Object reference not set to an instance of an object.
Test (Linux, ubuntu-latest, SingleThread)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Linux, ubuntu-latest, MultiThreaded)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Windows, windows-latest, SingleThread)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Windows, windows-latest, MultiThreaded)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "osu-test-results-Linux-MultiThreaded", "osu-test-results-Linux-SingleThread", "osu-test-results-Windows-MultiThreaded", "osu-test-results-Windows-SingleThread". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
osu-test-results-Linux-MultiThreaded
35.3 MB
osu-test-results-Linux-SingleThread
35.5 MB
osu-test-results-Windows-MultiThreaded
36.9 MB
osu-test-results-Windows-SingleThread
36.6 MB