Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify codec for audio files in Ranking criteria #12187

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ZoontS
Copy link

@ZoontS ZoontS commented Sep 22, 2024

Based on https://osu.ppy.sh/community/forums/topics/1574409

The ogg container supports a handful of audio and video codecs. However, osu only supports Vorbis for .ogg files

Self-check

Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

@Okorin Okorin added the state/blocked don't merge label Sep 22, 2024
@MChecaH
Copy link
Contributor

MChecaH commented Sep 22, 2024

Before proposing and requesting changes to any of the Ranking Criteria articles, please read through how to propose changes. The change proposed was never written in the correct forum thread, and so it never got the chance to be properly discussed with the community before being merged.

@Okorin
Copy link
Contributor

Okorin commented Sep 22, 2024

added the blocked label here for now

because while the change does make sense doing so based on a two year old resolved question with no other prior discussion in the corresponding forum doesn't align with how we do pass ranking criteria changes, refer to https://osu.ppy.sh/wiki/en/Ranking_criteria#proposing-changes

@Walavouchey
Copy link
Member

Walavouchey commented Sep 22, 2024

it might be correct, but is it necessary to specify? if the game doesn't support the codec the beatmap will simply not work, and i don't think anyone is ranking broken beatmaps

@ZoontS
Copy link
Author

ZoontS commented Sep 22, 2024

Before proposing and requesting changes to any of the Ranking Criteria articles, please read through how to propose changes. The change proposed was never written in the correct forum thread, and so it never got the chance to be properly discussed with the community before being merged.

added the blocked label here for now

because while the change does make sense doing so based on a two year old resolved question with no other prior discussion in the corresponding forum doesn't align with how we do pass ranking criteria changes, refer to https://osu.ppy.sh/wiki/en/Ranking_criteria#proposing-changes

I thought this change falls in the "Changes that do not alter the meaning or intention of the ranking criteria, such as improvements to spelling, grammar, or organisation, may not need a forum proposal." category since it doesn't really change anything apart from explicitly stating what is previously implicit

it might be correct, but is it necessary to specify? if the game doesn't support the codec the beatmap will simply not work, and i don't think anyone is ranking broken beatmaps

I think it is necessary to specify that vorbis must be used in .ogg files, either in ranking criteria page or somewhere else. I also came accross this thread which said opus files in .ogg format works fine in stable but not in website or lazer although i haven't tested this myself

@Okorin
Copy link
Contributor

Okorin commented Sep 22, 2024

Ok my bad for phrasing it like this, i basically just wanted to block this for now so we have an opportunity to

  1. figure out if it's supposed to be just Vorbis or any other codecs
  2. can retroactively create the thread & announce it to BNs so people are informed that something changed there and they should look at the RC again

posted it in the RC subforum for now : https://osu.ppy.sh/community/forums/topics/1981019?n=1

@ZoontS
Copy link
Author

ZoontS commented Sep 23, 2024

Ok my bad for phrasing it like this, i basically just wanted to block this for now so we have an opportunity to

1. figure out if it's supposed to be just Vorbis or any other codecs

2. can retroactively create the thread & announce it to BNs so people are informed that something changed there and they should look at the RC again

posted it in the RC subforum for now : https://osu.ppy.sh/community/forums/topics/1981019?n=1

No worries, thank you for helping

@Okorin
Copy link
Contributor

Okorin commented Sep 28, 2024

I took the liberty of directly applying the suggestion from the ranking criteria forum thread

Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cl8n cl8n removed the state/blocked don't merge label Oct 1, 2024
Copy link
Contributor

@mcendu mcendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly clayton's suggestion on the forums. I think Ogg Vorbis is likely the only unfamiliar name here; MP3 and WAV are easily recognizable. Suggested wording for the sample format rule:

...be uncompressed (.wav) or encoded in Ogg Vorbis (.ogg). MP3 (.mp3) should not be used here as it is inherently delayed.

PR title should be edited.

wiki/Ranking_criteria/en.md Outdated Show resolved Hide resolved
@ZoontS
Copy link
Author

ZoontS commented Oct 2, 2024

PR title should be edited.

Am I the only one who can edit it? If yes, what should be the new title? And should I commit the suggested change?
Sorry for the many questions, this is my first pull request

@mcendu
Copy link
Contributor

mcendu commented Oct 4, 2024

Am I the only one who can edit it? If yes, what should be the new title? And should I commit the suggested change? Sorry for the many questions, this is my first pull request

This PR is heading toward replacing extension name mentions of audio files with the actual codecs in use, so "Use codec for audio files in Ranking Criteria" would be a good one. Feel free to commit the suggested change too if you don't disagree with it, but that suggested change don't cover the sample format rule and you might have to apply that manually.

peppy
peppy previously approved these changes Oct 4, 2024
@ZoontS ZoontS changed the title Specify audio codec for .ogg files in Ranking criteria Specify codec for audio files in Ranking criteria Oct 6, 2024
@ZoontS ZoontS requested a review from cl8n October 6, 2024 09:04
@ZoontS
Copy link
Author

ZoontS commented Oct 6, 2024

Changed .wav to uncompressed WAV (.wav) and edited other mentions of mp3, ogg, and wav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants