-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify codec for audio files in Ranking criteria
#12187
base: master
Are you sure you want to change the base?
Conversation
Thank you for contributing to the osu! wiki. Please take note of the following:
See the contribution guide for more information. All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the |
Before proposing and requesting changes to any of the |
added the blocked label here for now because while the change does make sense doing so based on a two year old resolved question with no other prior discussion in the corresponding forum doesn't align with how we do pass ranking criteria changes, refer to https://osu.ppy.sh/wiki/en/Ranking_criteria#proposing-changes |
it might be correct, but is it necessary to specify? if the game doesn't support the codec the beatmap will simply not work, and i don't think anyone is ranking broken beatmaps |
I thought this change falls in the "Changes that do not alter the meaning or intention of the ranking criteria, such as improvements to spelling, grammar, or organisation, may not need a forum proposal." category since it doesn't really change anything apart from explicitly stating what is previously implicit
I think it is necessary to specify that vorbis must be used in .ogg files, either in ranking criteria page or somewhere else. I also came accross this thread which said opus files in .ogg format works fine in stable but not in website or lazer although i haven't tested this myself |
Ok my bad for phrasing it like this, i basically just wanted to block this for now so we have an opportunity to
posted it in the RC subforum for now : https://osu.ppy.sh/community/forums/topics/1981019?n=1 |
No worries, thank you for helping |
I took the liberty of directly applying the suggestion from the ranking criteria forum thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly clayton's suggestion on the forums. I think Ogg Vorbis is likely the only unfamiliar name here; MP3 and WAV are easily recognizable. Suggested wording for the sample format rule:
...be uncompressed (
.wav
) or encoded in Ogg Vorbis (.ogg
). MP3 (.mp3
) should not be used here as it is inherently delayed.
PR title should be edited.
Am I the only one who can edit it? If yes, what should be the new title? And should I commit the suggested change? |
This PR is heading toward replacing extension name mentions of audio files with the actual codecs in use, so "Use codec for audio files in |
Ranking criteria
Ranking criteria
Co-authored-by: Nathan Du <[email protected]>
Changed |
Based on https://osu.ppy.sh/community/forums/topics/1574409
The ogg container supports a handful of audio and video codecs. However, osu only supports Vorbis for .ogg files
Self-check