Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Loved polls on beatmapset pages #9451

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Show Loved polls on beatmapset pages #9451

wants to merge 14 commits into from

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Nov 2, 2022

for management, this also adds special loved API scope that can't be implied by * and needs to be requested by a designated client

resolves #8202

@cl8n cl8n marked this pull request as ready for review November 7, 2022 05:54
@notbakaneko notbakaneko self-requested a review November 14, 2022 11:34
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this loved client for, where and how is it going to be used?

Also, all the OAuth-related parts should be separated into a different PR.

@cl8n
Copy link
Member Author

cl8n commented Dec 3, 2022

@notbakaneko I put the oauth changes in #9584 , that's ready for review.

I'm gonna mark this one as draft and revisit / probably split it into more manageable parts after figuring out the oauth part.

@cl8n cl8n marked this pull request as draft December 3, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visibility of polls for beatmaps nominated for Loved
2 participants