Exclude bot and no profile special groups from being set as guest mappers #11764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted supporter tags)
nanaya
reviewed
Jan 6, 2025
| @@ -35,8 +35,7 @@ public function index() | |||
| } | |||
|
|
|||
| $users = User::where(fn ($q) => $q->whereIn('user_id', $numericIds)->orWhereIn('username', $stringIds)) | |||
| ->where('group_id', '<>', app('groups')->byIdentifier('no_profile')->getKey()) | |||
| ->default() | |||
| ->defaultForLookup() | |||
There was a problem hiding this comment.
this also affects user card which we probably want to keep showing for bots?
edit: it's actually even worse with the card saying the user doesn't exist...
nanaya
requested changes
Jan 16, 2025
| @@ -35,13 +40,15 @@ public function index() | |||
| } | |||
|
|
|||
| $users = User::where(fn ($q) => $q->whereIn('user_id', $numericIds)->orWhereIn('username', $stringIds)) | |||
| ->where('group_id', '<>', app('groups')->byIdentifier('no_profile')->getKey()) | |||
There was a problem hiding this comment.
I think this should stay regardless of exclude bots option? See #6736
nanaya
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11752
Also changes Chat Announcements and supporter tag gift lookups from the UI to exclude those groups, but I didn't change the actual check where those are applied yet.