Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2x support for news cover image #11604

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Oct 30, 2024

I looked into cleaning up the underlying firstImage in markdown processor but that was a can of worms and so I put the lid back on ノ(° -°ノ)

Resolves #11599

  • check if there's missing 2x image maybe?

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems working

@notbakaneko notbakaneko enabled auto-merge November 6, 2024 12:23
@notbakaneko notbakaneko merged commit c1f99b7 into ppy:master Nov 6, 2024
2 of 3 checks passed
@nanaya nanaya deleted the news-post-2x branch December 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News banner @2x images don't display anymore
2 participants