Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native uuid generator function #11587

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Oct 24, 2024

It's been a thing since 2022 (thx safari).

@notbakaneko notbakaneko merged commit 5dca88c into ppy:master Oct 24, 2024
3 checks passed
@notbakaneko
Copy link
Collaborator

A note that safari need needs the site to be https for it to work

@nanaya
Copy link
Collaborator Author

nanaya commented Oct 24, 2024

wow this secure context thing is kinda garbage 😐 at least all of our deployments are https and localhost is assumed secure...

@notbakaneko
Copy link
Collaborator

huh, I guess blank tab is considered secure context in Chrome but not Safari 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants