-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better ApiDoc definitions #11433
Draft
notbakaneko
wants to merge
29
commits into
ppy:master
Choose a base branch
from
notbakaneko:docs/missing-param-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Better ApiDoc definitions #11433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
force-pushed
the
docs/missing-param-types
branch
from
September 11, 2024 00:37
7fa88bc
to
fd45cbd
Compare
I wonder if all the default limit should be unified to the const |
notbakaneko
force-pushed
the
docs/missing-param-types
branch
from
September 18, 2024 09:02
c9b458d
to
b5d7347
Compare
notbakaneko
force-pushed
the
docs/missing-param-types
branch
from
September 18, 2024 09:13
b5d7347
to
f64d3fe
Compare
redraft again while I check if there was something else to be updated after the other PR was merged 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing apidocs with wrong auto-generated examples, etc.
Moving repetitive definitions to attributes so their values can be set be params instead of repeating the whole thing every time. Using attributes because customizing the parsing for phpdoc blocks is not so great...
closes #11427
Draft while I get better ideas on handling paramsgoing to stop here for this part before the scope creeps forever