Add group history page #10430
Open
Add group history page #10430
+743
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2023
This also includes all groups the user can normally view, for use in a group selector
lol
cl8n
force-pushed
the
group-history-2
branch
from
ebcc04d
to
80eb4e3
Compare
nanaya
requested changes
Feb 20, 2024
nanaya
requested changes
May 28, 2024
Each way to update the current params (new search or "show more") now keeps its own state so that they can each abort the ongoing request and still function as expected. The disabled state of the buttons now reflect this Additionally the current params are updated immediately on starting a search, instead of when the request completes
nanaya
requested changes
Jun 20, 2024
| .always(action(() => this.loading = false)); | ||
| } | ||
|
|
||
| private readonly onMore = () => { |
There was a problem hiding this comment.
this should reset the url if new search is in progress
either that or replace the listing with spinner (or add overlay to it) maybe
| @observable private currentParams: GroupHistoryJson['params']; | ||
| @observable private events: UserGroupEventJson[]; | ||
| @observable private loading: 'more' | 'new' | false = false; | ||
| @observable private moreParams!: MoreParams | null; |
|
|
||
| // Update the query string of the URL when starting a new search. Remove | ||
| // "sort" from the query if it's set to the default | ||
| Turbolinks.controller.replaceHistory(updateQueryString(null, { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 4~ resolves #6216
full page screenshots
the search form is basically same as featured artists track search and the events list is basically same as user profile recent activity area. the icon BGs light up with the group's color, if it has one.
This page is now available at https://osu.ppy.sh/groups/history.