Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News banner @2x images don't display anymore #11599

Closed
Walavouchey opened this issue Oct 29, 2024 · 1 comment · Fixed by #11604
Closed

News banner @2x images don't display anymore #11599

Walavouchey opened this issue Oct 29, 2024 · 1 comment · Fixed by #11604

Comments

@Walavouchey
Copy link
Member

the news cover image used to display in a 2x size depending on resolution/browser via a srcset attribute, but it doesn't appear to be there anymore

image

image in screenshot
https://github.com/ppy/osu-wiki/blob/master/wiki/shared/news/banners/pp-sr-pippi.jpg (1000 width)
https://github.com/ppy/osu-wiki/blob/master/wiki/shared/news/banners/[email protected] (2000 width)

issue happens in all the places where news covers appear
https://osu.ppy.sh/ (logged in and logged out)
https://osu.ppy.sh/home/news
https://osu.ppy.sh/home/news/2024-10-28-performance-points-star-rating-updates

@nanaya
Copy link
Collaborator

nanaya commented Oct 29, 2024

I don't think that's ever a thing but yeah that's doable. Just need to make sure there's 2x version of all news header images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants