Merge pull request #11607 from nanaya/follow-limit

Limit maximum number of mappers that can be followed

.env.example

@@ -229,6 +229,7 @@ CLIENT_CHECK_VERSION=false
 # space delimited, list of groups (the identifier) which user can be renamed when inactive
 # USER_ALLOWED_RENAME_GROUPS="default"
 
+# USER_MAX_FOLLOWS=5000
 # USER_MAX_FRIENDS=250
 # USER_MAX_FRIENDS_SUPPORTER=500
 # USER_MAX_MULTIPLAYER_DURATION=14

app/Http/Controllers/FollowsController.php

@@ -70,6 +70,9 @@ public function index($subtype = null)
 
     public function store()
     {
+        if (\Auth::user()->follows()->count() >= $GLOBALS['cfg']['osu']['user']['max_follows']) {
+            return error_popup(osu_trans('follows.store.too_many'));
+        }
         $params = $this->getParams();
         $follow = new Follow($params);
 
@@ -89,7 +92,7 @@ public function store()
             dispatch(new UpdateUserMappingFollowerCountCache($params['notifiable_id']));
         }
 
-        return response([], 204);
+        return response(null, 204);
     }
 
     private function getParams()

config/osu.php

@@ -253,6 +253,7 @@
         'user_page_forum_id' => intval(env('USER_PAGE_FORUM_ID', 70)),
         'verification_key_length_hex' => 8,
         'verification_key_tries_limit' => 8,
+        'max_follows' => get_int(env('USER_MAX_FOLLOWS')) ?? 5000,
         'max_friends' => get_int(env('USER_MAX_FRIENDS')) ?? 250,
         'max_friends_supporter' => get_int(env('USER_MAX_FRIENDS_SUPPORTER')) ?? 500,
         'max_login_attempts' => get_int(env('USER_MAX_LOGIN_ATTEMPTS')) ?? 10,

resources/lang/en/follows.php

@@ -35,4 +35,8 @@
     'modding' => [
         'title' => 'beatmap discussion',
     ],
+
+    'store' => [
+        'too_many' => 'Follow limit reached.',
+    ],
 ];