Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --mod-option parameter to simulate command #224

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

minisbett
Copy link
Contributor

@minisbett minisbett commented Oct 18, 2024

Depends on #223

This adds a mod option parameter for specifying mod settings. The syntax is -o|--mod-option <acronym>_<setting>=<value>.
Example: dotnet run -- simulate osu 4697929 -m DT -m DA -o DT_speed_change=1.3 -o DA_overall_difficulty=1

Additionally, this PR removes the --output parameter as it was deemed unecessary (any shell allows you do write to a file via | or >) and used the -o parameter already.

@minisbett minisbett marked this pull request as draft October 18, 2024 20:35
@minisbett minisbett marked this pull request as ready for review October 18, 2024 20:48
@smoogipoo smoogipoo merged commit 27dbd33 into ppy:master Oct 23, 2024
3 checks passed
@minisbett minisbett deleted the mod-options-parameter branch October 23, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants