Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tablet input handler on start #218

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

stanriders
Copy link
Member

Some people are having native driver crashes because of OTD being enabled by default

@smoogipoo smoogipoo merged commit 0a98cd6 into ppy:master Oct 9, 2024
3 checks passed
@peppy
Copy link
Member

peppy commented Oct 9, 2024

Wouldn't this imply the same thing would happen on lazer? Or is there something specifically different here?

What do the crashes look like?

@stanriders stanriders deleted the disable-tablets branch October 9, 2024 05:53
@stanriders
Copy link
Member Author

Wouldn't this imply the same thing would happen on lazer? Or is there something specifically different here?

What do the crashes look like?

That would happen on lazer too I believe, but there you have a toggle to disable the tablet driver and it wont interfere anymore.

Lazer's tablet driver crashes xp-pen's tablet driver. It was reported by a user, and I didn't really ask for additional details since disabling tablet input in tools is definitely something we'd want to do anyway (because it'd interfere if for example user tries to play the game at the same time as tools are open, or just manufacturers drivers that are open in background being unhappy)

@peppy
Copy link
Member

peppy commented Oct 9, 2024

SO just one user, or multiple? "Some people" implies more than one.

Could you please include the raw reports of this issue here so we can actually look to fix it if required? I don't think this kind of change should be made to an auxiliary project like this for one user. If it's an issue with xppen drivers we'd want to apply some kind of fix.

@stanriders
Copy link
Member Author

I didn't consider this important enough, as it's expected that having two drivers for one device isn't a good idea and might lead to one of them breaking, and again disabling tablet input in tools is something that should be done anyway.

I'll ask for more details about the crash

@BunnyTub
Copy link

BunnyTub commented Oct 12, 2024

I did have this issue with my Wacom tablet before (kept drivers installed for other uses), but stopped being an issue when I destroyed the drivers and switched to osu!'s OpenTabletDriver, then a bit after that, switched to the OpenTabletDriver daemon (with osu!'s OpenTabletDriver disabled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants