Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connection failures have way too much impact #184

Open
bdach opened this issue Aug 31, 2023 · 0 comments
Open

Redis connection failures have way too much impact #184

bdach opened this issue Aug 31, 2023 · 0 comments

Comments

@bdach
Copy link
Collaborator

bdach commented Aug 31, 2023

@ThePooN discovered during some infra work that a Redis connection failure will bring down spectator flows completely with

image

As is, redis definitely wasn't supposed to be this service-critical as its only purpose was delivering user statistics updates which should not be bringing down the entirety of spectator flows. It was definitely not intended, and is only happening due to DI behaviour foibles combined with signalr design (tl;dr: hubs are instantiated per client RPC call, which means that a service failing to resolve - such as IConnectionMultiplexer - will cause all of the operations that touch that hub to fail).

We probably need to put some kind of backstop against that happening in place. Or possibly even reconsider osu-server-spectator middlemanning in this process whatsoever and take a look at something like https://centrifugal.dev/ instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant