Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted DB pooling value #34

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

smoogipoo
Copy link
Contributor

The condition is currently equivalent to if (str == "False" && str != "0"), i.e.:

  • default => false
  • "true" (let's assume regardless of capitalisation, though that's not the case in practice) => false
  • "1" => false
  • "0" => false
  • "false" => true

Let's... not do this whole other parsing thingamajig. We haven't needed it until now.

@smoogipoo smoogipoo requested a review from peppy November 1, 2024 08:55
@peppy peppy merged commit 001e033 into ppy:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants