Ws RC and Catalog changes

[michaelkad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[michaelkad]

SDK Changes needed

func (r *resourceCatalog) GetServiceName(serviceID string) (string, error) {
	request := rest.GetRequest(helpers.GetFullURL(*r.client.Config.Endpoint, "/api/v1/"+serviceID))
	resp := map[string]interface{}{}
	_, err := r.client.SendRequest(request, &resp)
	if err != nil {
		return "", err
	}
	if resp["kind"] == "runtime" || resp["kind"] == "service" || resp["kind"] == "iaas" || resp["kind"] == "platform_service" || resp["kind"] == "template" || resp["kind"] == "composite" {
		if name, ok := resp["name"].(string); ok {
			return name, nil
		}
		return "", nil
	}
	return "", bmxerror.New(ErrCodeServiceDoesnotExist,
		fmt.Sprintf("Given service : %q doesn't exist", serviceID))
}

In FindByName

func isService(e models.Service) bool {
	// TODO: COS is 'iaas' kind, but considered to be a service
	if e.Kind == "service" || e.Kind == "iaas" || e.Kind == "composite" {
	
		return true
	}
	return false
}

[michaelkad]

Not needed.