Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace create workspace delete resource to terraform provider #14

Closed
wants to merge 4 commits into from

Conversation

ismirlia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ismirlia ismirlia requested a review from michaelkad November 17, 2023 17:47
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ismirlia some comments! And Once we have the SDK released we can add it to this.

website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "" is not needed.

website/docs/r/pi_workspace.html.markdown Outdated Show resolved Hide resolved
@ismirlia ismirlia requested a review from michaelkad November 20, 2023 05:11
@ismirlia ismirlia force-pushed the workspace-create-v2 branch 4 times, most recently from f4f9412 to 4442c4b Compare November 21, 2023 00:08
Add waiting to code to finish wait creating workspace

Fix workspace delete

Add workspace documentation

Increase workspace create timeout

Update workspace description

Remove extra quotes

Update dependencies

Update dependencies

temp
@ismirlia ismirlia force-pushed the workspace-create-v2 branch from 4442c4b to 86ec189 Compare November 21, 2023 00:09
@michaelkad
Copy link
Collaborator

@ismirlia this PR can be closed as well.

@ismirlia ismirlia closed this Jan 18, 2024
@michaelkad michaelkad deleted the workspace-create-v2 branch March 6, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants