Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor resource network-port and documentation #100

Closed
wants to merge 2 commits into from
Closed

Refactor resource network-port and documentation #100

wants to merge 2 commits into from

Conversation

Diptipowervs
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs requested a review from ismirlia March 19, 2024 17:55
michaelkad
michaelkad requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could update the constant? with prefix Arg_ and double check that is not already created as well

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved
ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved
ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved
@Diptipowervs Diptipowervs requested a review from michaelkad March 26, 2024 07:27
@michaelkad
Copy link
Collaborator

Opened #124

@michaelkad michaelkad closed this May 22, 2024
@michaelkad michaelkad deleted the resource-network branch September 6, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia Awaiting requested review from ismirlia

@michaelkad michaelkad Awaiting requested review from michaelkad

Assignees
No one assigned
Labels
Refactor Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Diptipowervs @michaelkad