Arith machine (field operations only) for BabyBear field #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Sep 10, 2024
|
build is failing. @qwang98 is this ready for review? |
|
@leonardoalt Can merge when approved. |
leonardoalt
reviewed
Jan 16, 2025
Fixed and let's wait for it to complete again :) |
leonardoalt
reviewed
Jan 16, 2025
| #[ignore = "Too slow"] | ||
| fn arith256_small_test() { | ||
| let f = "std/arith256_small_test.asm"; | ||
| regular_test_small_field(f, &[]); |
There was a problem hiding this comment.
Wait, we already have a similar test though, didn't we merge this already? Check 2 tests up
There was a problem hiding this comment.
Nope. It's different. Arith_small does 32 bit number mul and div, which combined with add_sub_small, satisfies our uses in the riscv machine.
Arith256 (this PR) does 256 bit number arith.
There was a problem hiding this comment.
ah yes true, I remember now
leonardoalt
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 256 bit version decomposed to 16 bit limbs, but not immediately needed by our BabyBear RISCV VM. Keeping it here though in case needed in the future.
Adapted
eq0only from our original arith machine. Exposes one operation that should work for add, sub, mul, div. Inputs are 16 bits. Decomposed to 8 bit intermediate columns for constraints.All original test vectors passed. Original comments not fully cleaned up though.