Raise error on blackboxes with type parameter

povik · Nov 1, 2024 · 45aaf76 · 45aaf76
1 parent 54f0cf5
commit 45aaf76
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/src/diag.cc b/src/diag.cc
@@ -49,6 +49,7 @@ namespace diag {
 	slang::DiagCode BadInlinedPortConnection(slang::DiagSubsystem::Netlist, 1035);
 	slang::DiagCode NoParamsOnUnkBboxes(slang::DiagSubsystem::Netlist, 1037);
 	slang::DiagCode ConnNameRequiredOnUnkBboxes(slang::DiagSubsystem::Netlist, 1038);
+	slang::DiagCode BboxTypeParameter(slang::DiagSubsystem::Netlist, 1039);
 
 	slang::DiagGroup unsynthesizable("unsynthesizable", {IffUnsupported, SignalSensitivityAmbiguous, GenericTimingUnsyn, BothEdgesUnsupported, ExpectingIfElseAload,
 														 IfElseAloadPolarity, IfElseAloadMismatch});
@@ -146,6 +147,9 @@ namespace diag {
 
 		engine.setMessage(ConnNameRequiredOnUnkBboxes, "port name required in connections on unknown blackboxes");
 		engine.setSeverity(ConnNameRequiredOnUnkBboxes, slang::DiagnosticSeverity::Error);
+
+		engine.setMessage(BboxTypeParameter, "blackbox cannot have a type parameter");
+		engine.setSeverity(BboxTypeParameter, slang::DiagnosticSeverity::Error);
 	}
 };
 };
diff --git a/src/diag.h b/src/diag.h
@@ -46,6 +46,7 @@ extern slang::DiagCode AloadOne;
 extern slang::DiagCode BadInlinedPortConnection;
 extern slang::DiagCode NoParamsOnUnkBboxes;
 extern slang::DiagCode ConnNameRequiredOnUnkBboxes;
+extern slang::DiagCode BboxTypeParameter;
 void setup_messages(slang::DiagnosticEngine &engine);
 };
 };
diff --git a/src/slang_frontend.cc b/src/slang_frontend.cc
@@ -2505,6 +2505,8 @@ struct PopulateNetlist : public TimingPatternInterpretor, public ast::ASTVisitor
 
 			sym.body.visit(ast::makeVisitor([&](auto&, const ast::ParameterSymbol &symbol) {
 				cell->setParam(RTLIL::escape_id(std::string(symbol.name)), convert_const(symbol.getValue()));
+			}, [&](auto&, const ast::TypeParameterSymbol &symbol) {
+				sym.body.addDiag(diag::BboxTypeParameter, symbol.location);
 			}, [&](auto&, const ast::InstanceSymbol&) {
 				// no-op
 			}));