Fix regex generated for special characters #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How relevant are those checks ? Node 14 reached EOL 3 years and 6 months ago and security patches 6 months ago ? I don't see how my changes could cause these failures 😕 |
|
Hey, thanks for working on this! I don't think it's the Node versions and it's definitely not your code, something's wrong with NPM in GitHub Actions. @Scrum any ideas as to why this may be happening? This makes me think it can't read the package.json so |
|
Yes, I accidentally updated the lock file to version 3, I'll fix it now |
|
@jbreton rebase to master please. |
jbreton
force-pushed
the
invalid-regex
branch
from
99e0575 to
3c655e1
Compare
|
@Scrum rebase done 👍🏻 |
|
@jbreton publish 1.11.3 |
|
@Scrum @cossssmin Awesome! thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#157 introduced a bug resulting in an invalid regex if custom delimiters are starting with a regex special character.